mikemccand commented on pull request #128:
URL: https://github.com/apache/lucene/pull/128#issuecomment-847885348
OK I ran `CheckIndex`, with this PR, on last night's English Wikipedia
benchmark index:
```
beast3:core[main]$ java -cp
../core/build/libs/lucene-core-9.0.0-SNAPSHOT.jar
org.apache.lucene.index.CheckIndex /l/indices/trunk.nightly.index.prev/index
NOTE: testing will be more thorough if you run java with
'-ea:org.apache.lucene...', so assertions are enabled
Opening index @ /l/indices/trunk.nightly.index.prev/index
Exception in thread "main" java.lang.IllegalArgumentException
at
java.base/java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:1295)
at
java.base/java.util.concurrent.ThreadPoolExecutor.<init>(ThreadPoolExecutor.java:1217)
at
java.base/java.util.concurrent.Executors.newFixedThreadPool(Executors.java:155)
at org.apache.lucene.index.CheckIndex.checkIndex(CheckIndex.java:527)
at org.apache.lucene.index.CheckIndex.doCheck(CheckIndex.java:4036)
at org.apache.lucene.index.CheckIndex.doMain(CheckIndex.java:3920)
at org.apache.lucene.index.CheckIndex.main(CheckIndex.java:3852)
```
I think the issue is that `opts.threadCount` is `0` if you don't explicitly
set the thread count. Can we fix it to default to number of cores on the box,
maybe capped at a maximum (4?
8?), when `CheckIndex` is invoked interactively from the command-line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
