mikemccand commented on pull request #146: URL: https://github.com/apache/lucene/pull/146#issuecomment-869757664
> The branch this PR is built in has multiple commits. For clarity about the contents of the commit message should I squash these down before it gets merged or should I leave squashing commits to the person doing the merging? No need for you to pre-squash -- we can do that when merging. GitHub gives us this convenient "Squash and Merge" (by default) button for just that. I'll merge these added test cases soon. Thanks @gautamworah96! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
