jtibshirani commented on pull request #207: URL: https://github.com/apache/lucene/pull/207#issuecomment-878677846
+1 to keeping the name `VectorValues`. Otherwise the changes look good to me too. One thought: I actually find the "Nn" prefix hard to read/ type, it almost looks like a typo. For me either "NN" or "Knn" (which is @msokolov's preferred option) would be more elegant. I really don't mean to nitpick, and understand it was difficult to reach a decision, so feel free to ignore this comment if you'd like :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
