[ 
https://issues.apache.org/jira/browse/LUCENE-10016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382201#comment-17382201
 ] 

Julie Tibshirani commented on LUCENE-10016:
-------------------------------------------

I also didn't see a precedent for it. It seemed okay to me, but understand your 
concern. I'm not sure reader attributes would work because it could be common 
to adjust these parameters per-request.

Coming back to this, I may have been too worried about this API simplification. 
The vectors format is experimental, and it's always possible to evolve it when 
we consider new NN algorithms. This sort of change is self-contained and 
doesn't affect index format. So perhaps we could move ahead with it but make 
sure to keep in mind that not all algorithms fit into this mold?

> VectorReader.search needs rethought, o.a.l.search integration?
> --------------------------------------------------------------
>
>                 Key: LUCENE-10016
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10016
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>            Priority: Blocker
>             Fix For: 9.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There's no search integration (e.g. queries) for the current vector values, 
> no documentation/examples that I can find.
> Instead the codec has this method:
> {code}
> TopDocs search(String field, float[] target, int k, int fanout)
> {code}
> First, the "fanout" parameter needs to go, this is specific to HNSW impl, get 
> it out of here.
> Second, How am I supposed to skip over deleted documents? How can I use 
> filters? How should i search across multiple segments?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to