gautamworah96 opened a new pull request #242: URL: https://github.com/apache/lucene/pull/242
<!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene: * https://issues.apache.org/jira/projects/LUCENE You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> LUCENE must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description The current `count` method in `IndexSearcher` has some basic optimizations that rely on `instanceof` checks for checking the specific type of Query and then applying the appropriate optimization. This approach is not feasible for optimizations to more `Query` classes. By adding a `Weight#count(LeafReaderContext)` method, each `Query` class can optimize its own `Weight` class (created using `.createWeight`) and override the `count` function accordingly. For example, a `MatchNoDocsQuery` can by default return 0 as the count for any input query. # Solution Add a default `BulkScorer` + `TotalHitCountCollector` implementation in Weight.java and add sample faster implementations in MatchAllDocsQuery, MatchNoDocsQuery, TermQuery # Tests Add tests for `BooleanQuery` and `TermQuery` that test the `Weight#count` function # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
