[
https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404195#comment-17404195
]
Mark Robert Miller commented on LUCENE-10002:
---------------------------------------------
I did this some time ago. Read in Mike's blog you can just toss in an executor,
tossed it, looked for my that was easy button.
+1 on making it obvious that I literally had changed nothing. Unfortunately,
would not have saved me from the complications around implementing the "map
reduce" collectors, all hopefully efficiently, and working out when it makes
sense to use them vs the std search method, given the overhead and the index
size and number of segments needed to make the tradeoff worth it, or at least
not a performance hit. Or working out how to deal with changing segment count
makeup, what kind of merge control or shenanigans make sense when or how and
when and why to manage the segment slices and how they are grouped. Etc. Etc.
Went from, "drop in an executor? sweet" to ...
> Remove IndexSearcher#search(Query,Collector) in favor of
> IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10002
> URL: https://issues.apache.org/jira/browse/LUCENE-10002
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but
> that it would always search on the caller thread when calling
> {{IndexSearcher#search(Query,Collector)}}.
> Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to
> {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory
> methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to
> return a {{CollectorManager}} instead of a {{Collector}}?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
