mikemccand commented on pull request #264: URL: https://github.com/apache/lucene/pull/264#issuecomment-906343623
I think a simple approach for the back-compat is to switch on `SegmentInfos.getIndexCreatedVersionMajor()`. If the index was created pre-8.10, then we use the legacy encoding (`BDV`). Else, we use the new encoding (`SSDV`). This avoids having the same field name trying to use two different doc-values types, mixing old and new segments in the index, etc. The code/switching is simpler. But one downside is that users must fully create an entirely new index to get the benefits of the new encoding -- they cannot just upgrade Lucene and `.forceMerge(1)` and get the new tech. I think that's a fine tradeoff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
