wuda0112 commented on pull request #224: URL: https://github.com/apache/lucene/pull/224#issuecomment-907810690
> > > So awesome that `SimpleText` is finally getting a skipping implementation! Thank you @wuda0112! > > > Have you tried stressing out the new code by running all Lucene unit-tests with `SimpleText`? Something like `./gradlew -Dtests.codec=SimpleText`. > > > > > > @mikemccand Thanks for your reply! I have execute `./gradlew check` `./gradlew test` `./gradlew -p lucene/core/ test` `./gradlew -p lucene/codecs/ test`, and all passed! > > But when i execute `./gradlew test -Dtests.codec=SimpleText`, there has one FAILED, the exception is: > > ``` > > org.apache.lucene.demo.TestDemo > testKnnVectorSearch FAILED > > java.lang.UnsupportedOperationException > > at __randomizedtesting.SeedInfo.seed([2DAF064A760C3554:7F0D5D18D85E7028]:0) > > at org.apache.lucene.codecs.simpletext.SimpleTextKnnVectorsReader.search(SimpleTextKnnVectorsReader.java:143) > > ``` > > > > > > > > > > > > > > > > > > > > > > > > when i look into SimpleTextKnnVectorsReader#search, it `throw new UnsupportedOperationException` > > Ahh it looks like `SimpleText` is missing its KNN implementation but looks like it's coming soon! https://issues.apache.org/jira/browse/LUCENE-10063. In the meantime that failing test should add an `assume` that the current codec is not `SimpleText`. Ok, got it, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
