rmuir commented on pull request #308: URL: https://github.com/apache/lucene/pull/308#issuecomment-922893171
> OutputStreamIndexOutput should be looked at a separate issue. I'm not sure about this: doesn't seem like the right tradeoff. Would certainly make the code here more complicated due to the way we use JDK outputstream decorators for both buffering and checksum. I'd hate to see that logic duplicated unless there's a real benchmarking showing real indexing improvement (JMH doesn't count here). If we want to reduce the overhead of this packing/unpacking during indexing, maybe it is best to start with the jazillion of complicated byte[] buffers in indexwriter (byteblockpool, pagedbytes, ...). There are so many of these... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
