[
https://issues.apache.org/jira/browse/LUCENE-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17423579#comment-17423579
]
Robert Muir commented on LUCENE-10143:
--------------------------------------
Why not just make it abstract, forcing the caller to decide what to do (example
readInt):
1. implement it efficiently (e.g. varhandle) on some buffer or whatever
2. delegate to readIntSlowly() to do what happens already.
3. delegate it to some sub-stream it is wrapping.
It's always a one-liner still this way, we just force the subclass to be
explicit? And maybe the slow methods don't have to be deprecated: e.g. for the
mmap case, it is so rare, that it is perfectly ok to use for now across
boundaries (because files are not aligned).
> RateLimitedIndexOutput should delegate writeShort/writeInt/writeLong
> --------------------------------------------------------------------
>
> Key: LUCENE-10143
> URL: https://issues.apache.org/jira/browse/LUCENE-10143
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
>
> Otherwise merges are not taking advantage of LUCENE-10125.
> cc [~uschindler]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
