rmuir opened a new pull request #348: URL: https://github.com/apache/lucene/pull/348
Make the following methods abstract: * DataInput.readShort * DataInput.readInt * DataInput.readLong * DataOutput.writeShort * DataOutput.writeInt * DataOutput.writeLong In javadocs of each, reference both the relevant BitUtil VH constant, and a protected slow fallback implementation (e.g. readShortSlowly). Slow implementations document that they read/write bytes one-at-a-time Not all subclasses were fixed to be fast: some have TODOs. I only fixed subclasses to be fast if it was completely 100% obvious to me. There are a lot of TODOs, feel free to push stuff to my branch (as long as tests pass!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
