uschindler commented on a change in pull request #348:
URL: https://github.com/apache/lucene/pull/348#discussion_r721174730
##########
File path:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataInput.java
##########
@@ -103,6 +103,24 @@ public byte readByte() throws EOFException {
}
}
+ @Override
+ public short readShort() throws IOException {
+ // TODO: use ByteBuffer.getShort
Review comment:
In general we should also clarify the DataInput/DataOutput APIs to
explicitely document how each methods needs to behave. The
read/writeInt/Long/Short should mention that byte order is little endian in
9.0. That's missing in the specs and leads to confusion for people who
implement their own DataInput/DataOutput (custom directories). Now that it is
required to implement the method (as it is abstract), it should specify how it
should behave.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
