[
https://issues.apache.org/jira/browse/LUCENE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17424264#comment-17424264
]
Animesh Pandey edited comment on LUCENE-9431 at 10/5/21, 2:32 AM:
------------------------------------------------------------------
[~dsmiley] Hi, I wanted to confirm if my understanding is correct regarding
this issue. By making WEIGHT_MATCHES as default, do we mean that for
UnifiedHighlighter we just add HighlightFlag.WEIGHT_MATCHES to getFlags(String
field) method? I did that just to check what happens and I see like 20 unit
tests fail in uhighlight package.
According on LUCENE-8286, "Longer term it could go away and it'll be implied if
you specify enum values for PHRASES & MULTI_TERM_QUERY?". Does it mean that we
should be enabling WEIGHT_MATCHES when PHRASES & MULTI_TERM_QUERY are enabled?
was (Author: apanimesh061):
[~dsmiley] Hi, I wanted to confirm if my understanding is correct regarding
this issue. By making WEIGHT_MATCHES as default, do we mean that for
UnifiedHighlighter we just add HighlightFlag.WEIGHT_MATCHES to getFlags(String
field) method? I did that just to check what happens and I see like 20 unit
tests fail in uhighlight package.
> UnifiedHighlighter: Make WEIGHT_MATCHES the default
> ---------------------------------------------------
>
> Key: LUCENE-9431
> URL: https://issues.apache.org/jira/browse/LUCENE-9431
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/highlighter
> Reporter: David Smiley
> Priority: Minor
> Labels: newdev
> Fix For: main (9.0)
>
>
> This mode uses Lucene's modern mechanism of exposing information that
> previously required complicated highlighting machinery. It's also likely to
> generally work better out-of-the-box and with custom queries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
