janhoy commented on a change in pull request #1435:
URL: https://github.com/apache/lucene-solr/pull/1435#discussion_r723118782
##########
File path: solr/bin/install_solr_service.sh
##########
@@ -229,21 +229,21 @@ if [ -z "$SOLR_UPGRADE" ]; then
fi
if [ ! "$SOLR_UPGRADE" = "YES" ]; then
- if [ -f "/etc/init.d/$SOLR_SERVICE" ]; then
- print_usage "/etc/init.d/$SOLR_SERVICE already exists! Perhaps Solr is
already setup as a service on this host? To upgrade Solr use the -f option."
+ if [ -f "/etc/systemd/system/$SOLR_SERVICE.service" ]; then
Review comment:
Should the updated script also look for the old `/etc/init.d/solr`
service (could be installed for 8.x when trying to install 9.0), and abort, or
offer to uninstall the old init.d service script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]