msokolov commented on pull request #350: URL: https://github.com/apache/lucene/pull/350#issuecomment-938823886
Oh, sorry I am just catching up here. I like this solution. I'm also kind of annoyed that this slipped through before when I added the error message specialization (I think that must be when the autoboxing kicked in?). Somehow my perf measurements did not catch the regression. On Wed, Oct 6, 2021 at 5:46 AM Adrien Grand ***@***.***> wrote: > Actually there is an even simpler fix: the only long is dvGen which we > don't need to check since it's always -1. I'll update the PR description > accordingly. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene/pull/350#issuecomment-935862391>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHHUQIBN5ZXSHLSMCRJTLTUFQLGVANCNFSM5FJ3MARA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
