[ 
https://issues.apache.org/jira/browse/LUCENE-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17426406#comment-17426406
 ] 

Marcus Eagan commented on LUCENE-8637:
--------------------------------------

[~gol...@detego-software.de] Can you check if it breaks unit tests? Do you know 
how to run the whole suite?

> WeightedSpanTermExtractor unnexessarily enforces rewrite for some SpanQueiries
> ------------------------------------------------------------------------------
>
>                 Key: LUCENE-8637
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8637
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 7.4, 7.3.1, 7.5, 7.6
>            Reporter: Christoph Goller
>            Priority: Minor
>              Labels: patch
>         Attachments: WeightedSpanTermExtractor.java
>
>
> Method mustRewriteQuery(SpanQuery) returns true for SpanPositionCheckQuery, 
> SpanContainingQuery, SpanWithinQuery, and SpanBoostQuery, however, these 
> queries do not require rewriting. One effect of this is e.g. that 
> UnifiedHighlighter does not work with OffsetSource Postings and switches to 
> Analysis which of course has consequences for performance.
> I attach a patch for lucene version 7.6.0. I have not checked whether it 
> breaks existing unit tests.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to