janhoy commented on a change in pull request #355:
URL: https://github.com/apache/lucene/pull/355#discussion_r725914818
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -173,11 +173,15 @@ def checkJARMetaData(desc, jarFile, gitRevision, version):
if gitRevision != 'skip':
# Make sure this matches the version and git revision we think we are
releasing:
- # TODO: LUCENE-7023: is it OK that Implementation-Version's value now
spans two lines?
- verifyRevision = 'Implementation-Version: %s %s' % (version, gitRevision)
- if s.find(verifyRevision) == -1:
- raise RuntimeError('%s is missing "%s" inside its META-INF/MANIFEST.MF
(wrong git revision?)' % \
+ match = re.search("Implementation-Version: (.+\r\n .+)", s, re.MULTILINE)
Review comment:
I ported this change from branch_8x even if that was targeted to 8.x
only (don't know why), since we'll end up in same situation with 10.x some
time..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
