[ 
https://issues.apache.org/jira/browse/LUCENE-10180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429196#comment-17429196
 ] 

Adrien Grand edited comment on LUCENE-10180 at 10/15/21, 9:12 AM:
------------------------------------------------------------------

 !profile.png! 

Here is a profile generated by async-profiler to show what I'm talking about. 
There are two separate sub trees for points merges under SegmentMerger#merge 
because we get two lambdas that have different auto-generated names.




was (Author: jpountz):
I attached a profile generated by async-profiler to show what I'm talking 
about. There are two separate sub trees for points merges under 
SegmentMerger#merge because we get two lambdas that have different 
auto-generated names.



> Remove usage of lambdas in SegmentMerger?
> -----------------------------------------
>
>                 Key: LUCENE-10180
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10180
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: profile.png
>
>
> SegmentMerger now uses lambdas to share the logic around logging merging 
> times for all file formats.
> One problem is that these lambdas get auto-generated names, and it makes it 
> harder to work with profilers since things that should logically end up in 
> the same sub tree end up in different sub trees because two instances of the 
> same lambda get different names.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to