rmuir commented on pull request #389:
URL: https://github.com/apache/lucene/pull/389#issuecomment-945586019
Seems a lot easier to just test this via SORTED_NUMERIC. There isn't any
point in testing SORTED_SET as it only makes things more difficult.
The test should fail without the fix and pass with the fix, so there is no
"use" to be had otherwise.
As far as Asserting, maybe you misunderstand the issue. It does not happen
via the public API, so such a class cannot catch it? It happens via
implementation detail:
```
NumericDocValues ords = ... // fetch internal
return new SortedNumericDocvalues() { ... } // buggy delegator
```
Why do we have all this delegation?
If we truly must delegate, why not delegate docValueCount too?
I don't understand why we eagerly invoke it in next/advance and cache it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
