apanimesh061 commented on a change in pull request #412:
URL: https://github.com/apache/lucene/pull/412#discussion_r736078469
##########
File path:
lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/TestUnifiedHighlighter.java
##########
@@ -638,6 +674,39 @@ protected BreakIterator getBreakIterator(String field) {
ir.close();
}
+ // This is a copy of testHighlightAllText() where UnifiedHighlighter is
created using a builder.
+ public void testHighlightAllTextUsingBuilder() throws Exception {
Review comment:
Yes that makes sense. I was thinking in terms of checking if the default
builder is behaving like current default w/o builders. Based on your comment I
think that might not be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
