[
https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446638#comment-17446638
]
Greg Miller commented on LUCENE-10245:
--------------------------------------
Thanks [~romseygeek]! That was along the lines of my original thinking as well.
We discussed this a little bit on the dev list
[here|http://mail-archives.apache.org/mod_mbox/lucene-dev/202110.mbox/%3CCANJ0CDoJ%3DOaX1XefXtK5BUFRsHoBjigqooyDva9is_Br1zTA5A%40mail.gmail.com%3E],
but should evaluate both approaches further as part of this work I think. What
I like about the MulitXXXValues approach is that implementations don't need to
provide doc iteration capabilities. That's actually a nice fit for faceting
since the faceting implementations don't need to rely on the values for
iteration, so it might be a slightly better abstraction than asking users to
implement doc values (which requires iteration capabilities that aren't used...
or throwing UnsupportedOperations or something clunky like that).
> Allow users to provide DocValues to (some) Facets Implementations
> -----------------------------------------------------------------
>
> Key: LUCENE-10245
> URL: https://issues.apache.org/jira/browse/LUCENE-10245
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/facet
> Reporter: Greg Miller
> Priority: Minor
>
> We have some {{Facets}} implementations that do aggregations over numeric
> values associated with each doc (e.g., {{{}DoubleRangeFacetCounts{}}},
> {{{}LongValueFacetCounts{}}}, etc.). These implementations allow the user to
> either specify, 1) a field to source the doc values from, or 2) a custom
> source of values in the form of {{{}DoubleValueSource{}}},
> {{{}LongValueSource{}}}, etc.
> Unfortunately, these {{xxValueSource}} implementations don't support multiple
> values per doc, while indexed doc values do. So if the user has indexed doc
> values they want to facet over, it works just fine if docs are multi-valued.
> But if they want to provide a custom source of data, they're restricted to
> single-value only.
> We should consider allowing users to provide their own doc values instances
> in favor of the {{xxValueSource}} instances. (I'd propose we deprecate the
> {{xxValueSource}} approach)
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
