[ 
https://issues.apache.org/jira/browse/LUCENE-10245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17460030#comment-17460030
 ] 

Greg Miller commented on LUCENE-10245:
--------------------------------------

Just put up a PR for this work for feedback: 
[https://github.com/apache/lucene/pull/543]

[~romseygeek] I requested you as a reviewer since it sounds like you have a lot 
of historic context here and opinions. [~rmuir] I suspect you'll have opinions 
as well since we'd 
[discussed|http://mail-archives.apache.org/mod_mbox/lucene-dev/202110.mbox/%3CCANJ0CDoJ%3DOaX1XefXtK5BUFRsHoBjigqooyDva9is_Br1zTA5A%40mail.gmail.com%3E]
 this some on the dev-list a little while back, so I requested you as well. No 
rush on this of course. For starters, I'm curious what folks think about adding 
these new multi-valued "value source" concepts. Thanks everyone!

> Allow users to provide DocValues to (some) Facets Implementations
> -----------------------------------------------------------------
>
>                 Key: LUCENE-10245
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10245
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Greg Miller
>            Assignee: Greg Miller
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We have some {{Facets}} implementations that do aggregations over numeric 
> values associated with each doc (e.g., {{{}DoubleRangeFacetCounts{}}}, 
> {{{}LongValueFacetCounts{}}}, etc.). These implementations allow the user to 
> either specify, 1) a field to source the doc values from, or 2) a custom 
> source of values in the form of {{{}DoubleValueSource{}}}, 
> {{{}LongValueSource{}}}, etc.
> Unfortunately, these {{xxValueSource}} implementations don't support multiple 
> values per doc, while indexed doc values do. So if the user has indexed doc 
> values they want to facet over, it works just fine if docs are multi-valued. 
> But if they want to provide a custom source of data, they're restricted to 
> single-value only.
> We should consider allowing users to provide their own doc values instances 
> in favor of the {{xxValueSource}} instances. (I'd propose we deprecate the 
> {{xxValueSource}} approach)



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to