[ 
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17454023#comment-17454023
 ] 

David Smiley commented on LUCENE-10252:
---------------------------------------

I think this could reasonably be qualified as a perf regression bug (especially 
felt by Solr), applicable to 8.11 bug-fix release.  WDYT?  Admittedly I didn't 
detect it in such a way but nonetheless I'm sure calculating the score more 
than needed absolutely leads to a big performance loss in some cases, which I 
have run into in the past.

> ValueSource.asDoubleValues shouldn't fetch score
> ------------------------------------------------
>
>                 Key: LUCENE-10252
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10252
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/query
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The ValueSource.asDoubleValuesSource() method bridges the old API to the new 
> one.  It's rather important because boosting a query no longer has an old 
> API; in its place is using this method and passing to 
> FunctionScoreQuery.boostByValue.  Unfortunately, asDoubleValuesSource will 
> fetch/compute the score for the document in order to expose it in a Scorable 
> on the "scorer" key of the context Map.  AFAICT nothing in Lucene or Solr 
> actually uses this.  If it should be kept, the Scorable's score() method 
> could fetch it at that time (e.g. on-demand).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to