[ 
https://issues.apache.org/jira/browse/LUCENE-10252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467981#comment-17467981
 ] 

ASF subversion and git services commented on LUCENE-10252:
----------------------------------------------------------

Commit 72163649b16a909ba21baca4cb6d3840f60855e8 in lucene's branch 
refs/heads/branch_9x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=7216364 ]

LUCENE-10252: ValueSource.asDoubleValues should not compute the score (#519)

ValueSource.asDoubleValues and asLongValues should not compute the score unless 
asked to -- typically never.  This fixes a performance regression since 7.3 
LUCENE-8099 when some older boosting queries were replaced with this.

> ValueSource.asDoubleValues shouldn't fetch score
> ------------------------------------------------
>
>                 Key: LUCENE-10252
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10252
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/query
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The ValueSource.asDoubleValuesSource() method bridges the old API to the new 
> one.  It's rather important because boosting a query no longer has an old 
> API; in its place is using this method and passing to 
> FunctionScoreQuery.boostByValue.  Unfortunately, asDoubleValuesSource will 
> fetch/compute the score for the document in order to expose it in a Scorable 
> on the "scorer" key of the context Map.  AFAICT nothing in Lucene or Solr 
> actually uses this.  If it should be kept, the Scorable's score() method 
> could fetch it at that time (e.g. on-demand).



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to