[ 
https://issues.apache.org/jira/browse/LUCENE-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456419#comment-17456419
 ] 

ASF subversion and git services commented on LUCENE-10289:
----------------------------------------------------------

Commit 5e0d8dc87a9baf9040e958ae84b258d0967b0558 in lucene's branch 
refs/heads/branch_9x from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=5e0d8dc ]

Revert "LUCENE-10289: Change DocIdSetBuilder#grow() from taking an int to a 
long (#520)" (#532)

This reverts commit af1e68b89197bd6399c0db18e478716951dd381c.

> DocIdSetBuilder#grow() should take a long instead of int 
> ---------------------------------------------------------
>
>                 Key: LUCENE-10289
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10289
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Ignacio Vera
>            Assignee: Ignacio Vera
>            Priority: Major
>             Fix For: 9.1
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> DocIdSetBuilder accepts adding duplicates and therefore it potentially can 
> accept more than Integer.MAX_VALUE docs. For example, it already holds a 
> counter internally that is a long. It probably make sense to be able to grow 
> using a long instead of an int.
>  
> This will allow us to change PointValue.IntersectVisitor#grow() from int to 
> long and remove some unnecessary dance when we need to bulk add more that 
> Integer.MAX_VALUE points.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to