[
https://issues.apache.org/jira/browse/LUCENE-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468664#comment-17468664
]
Uwe Schindler commented on LUCENE-10352:
----------------------------------------
Here is now a first PR: https://github.com/apache/lucene/pull/582
- It compiles and I only had to copy 3 test resource files. We may simplify
them, so the modular integration test can use a limited set of resources.
- The StringMockResourceLoader was deduplicated and moved to test-framework
- A unused class inside TestRandomChains used only by TestBugInSomething was
moved
- The available snowball stemmers are also discovered from module system with
same code. This spares to copy the stemmers.txt file (which is autogenerated
and I did not want to change this)
What's broken:
- A few components have no factory. The problem was that tests were only
running in common, not all modules
- We need more argument providers for TestRandomChains, e.g. for ICU or
Morphologic Ctors.
To do a quick test, you can restrict the module discovery to only read
org.apache.lucene.core and org.apache.lucene.analysis.common. I marked a place
to comment in/out code
> Convert TestAllAnalyzersHaveFactories and TestRandomChains to a global
> integration test and discover classes to check from module system
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-10352
> URL: https://issues.apache.org/jira/browse/LUCENE-10352
> Project: Lucene - Core
> Issue Type: New Feature
> Components: modules/analysis
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently TestAllAnalyzersHaveFactories and TestRandomChains only work on the
> analysis-commons module, but e.g. we do not do a random chain with kuromoji
> and ICU. Also both tests rely on some hacky classpath-inspection and the
> tests fail if ran on a JAR file.
> This issue tracks progress I am currently doing to refactor this:
> - Move those 2 classes to a new gradle subproject
> :lucene:analysis:integration.tests and add a module-info referring to all
> other analysis packages
> - Rewrite the class discovery to use ModuleReader
> - Run TestAllAnalyzersHaveFactories per module (using one module reader), so
> it discovers all classes and ensures that factory and stream are in same
> module (there are some core vs. analysis.common discrepancies)
> - RunTestRandomChains on the whole module graph. The classes are discovered
> from all module readers in the graph (filtering on module name starting with
> "org.apache.lucene.analysis."
> - Also compare that the SPI factories returned by discovery match those we
> have in the module graphs
> While doing this I disovered some bad things:
> - TestRandomChains depends on test-only resources. We may need to replicate
> those (it is about 5 files that are fed into the ctors)
> - We have 5 different StringMockResourceLoaders: Originally it was only in
> analysis common, now its everywhere. I will move this class to
> test-framework. This is unrelated but can be done here. The background of
> this was that analysis factories and resource loaders were not part of lucene
> core, so the resourceloader interface couldn't be in test-framework.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
