gsmiller commented on a change in pull request #578:
URL: https://github.com/apache/lucene/pull/578#discussion_r779786913
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FastTaxonomyFacetCounts.java
##########
@@ -69,7 +69,7 @@ public FastTaxonomyFacetCounts(
countAll(reader);
}
- private final void count(List<MatchingDocs> matchingDocs) throws IOException
{
+ final void count(List<MatchingDocs> matchingDocs) throws IOException {
Review comment:
It looks like you made this pkg visible so you could reference it in the
`IntTaxonomyFacets` javadoc? I'd prefer we avoid opening up visibility just for
that reason, but maybe I'm overlooking some other reason why this should no
longer be private?
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/IntTaxonomyFacets.java
##########
@@ -31,10 +31,23 @@
/** Base class for all taxonomy-based facets that aggregate to a per-ords
int[]. */
public abstract class IntTaxonomyFacets extends TaxonomyFacets {
- /** Per-ordinal value. */
- private final int[] values;
+ /**
+ * Dense ordinal values.
+ *
+ * <p>We are making this and {@link #sparseValues} protected for some expert
usage. e.g. It can be
+ * checked which is being used before a loop instead of calling {@link
#increment} for each
+ * iteration.
Review comment:
Thanks for adding documentation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
