jpountz commented on a change in pull request #541:
URL: https://github.com/apache/lucene/pull/541#discussion_r782366414
##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDForUtil.java
##########
@@ -0,0 +1,126 @@
+// This file has been automatically generated, DO NOT EDIT
Review comment:
It no longer looks auto-generated? (which sounds good to me since it's
much simpler now)
##########
File path: lucene/core/src/java/org/apache/lucene/util/bkd/BKDForUtil.java
##########
@@ -0,0 +1,126 @@
+// This file has been automatically generated, DO NOT EDIT
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.util.bkd;
+
+import java.io.IOException;
+import org.apache.lucene.store.DataInput;
+import org.apache.lucene.store.DataOutput;
+
+// Inspired from https://fulmicoton.com/posts/bitpacking/
+// Encodes multiple integers in a long to get SIMD-like speedups.
+// If bitsPerValue <= 8 then we pack 8 ints per long
+// else if bitsPerValue <= 16 we pack 4 ints per long
+// else we pack 2 ints per long
+final class BKDForUtil {
+
+ static final int BLOCK_SIZE = 512;
+ private static final long MASK32_8 = mask32(8);
+ private static final long MASK32_24 = mask32(24);
+
+ private static long expandMask32(long mask32) {
+ return mask32 | (mask32 << 32);
+ }
+
+ private static long mask32(int bitsPerValue) {
+ return expandMask32((1L << bitsPerValue) - 1);
+ }
+
+ private static void expand16(long[] arr, final long base) {
Review comment:
Thanks for creating these micro benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
