[ https://issues.apache.org/jira/browse/LUCENE-10368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474868#comment-17474868 ]
Greg Miller commented on LUCENE-10368: -------------------------------------- Let's hold off on this change actually until we sort out the taxo-faceting performance regressions so we don't run into a mess of git merge conflicts (see LUCENE-10372). I'll post here once that's sorted and we're ready to move forward with this. I converted the PRs to DRAFT mode for the time-being. > Reduce visibility of IntTaxonomyFacets > -------------------------------------- > > Key: LUCENE-10368 > URL: https://issues.apache.org/jira/browse/LUCENE-10368 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/facet > Reporter: Greg Miller > Assignee: Greg Miller > Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > Opening this issue as a follow up from the conversation over here: > [https://github.com/apache/lucene/pull/578#discussion_r779353869] > I'd propose we reduce the visibility to {{pkg-private}} and do a little > cleanup. This is essentially indicating that {{IntTaxonomyFacets}} is an > internal implementation detail of taxonomy faceting (shared common logic) as > opposed to an intentional extension point for users. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org