[
https://issues.apache.org/jira/browse/LUCENE-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475181#comment-17475181
]
Adrien Grand commented on LUCENE-10376:
---------------------------------------
+1
> Roll up the loop in vint/vlong in DataInput
> -------------------------------------------
>
> Key: LUCENE-10376
> URL: https://issues.apache.org/jira/browse/LUCENE-10376
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Reporter: Feng Guo
> Priority: Minor
>
> This issue proposes to roll up the loop in {{{}DataInput#readVInt and
> {{DataInput#readVLong{}}}{}}}.
> Previous talk can be found here: [https://github.com/apache/lucene/pull/592.]
> Benchmark:
> {code:java}
> TaskQPS baseline StdDevQPS
> my_modified_version StdDev Pct diff p-value
> BrowseMonthTaxoFacets 5.17 (15.9%) 5.00
> (12.1%) -3.4% ( -27% - 29%) 0.446
> OrNotHighLow 1010.74 (4.0%) 978.71
> (4.6%) -3.2% ( -11% - 5%) 0.021
> HighPhrase 171.95 (3.6%) 166.92
> (4.6%) -2.9% ( -10% - 5%) 0.025
> AndHighLow 594.12 (4.2%) 577.24
> (5.4%) -2.8% ( -11% - 7%) 0.064
> OrHighLow 540.46 (4.1%) 526.17
> (5.4%) -2.6% ( -11% - 7%) 0.083
> OrHighMedDayTaxoFacets 6.01 (5.3%) 5.88
> (3.9%) -2.2% ( -10% - 7%) 0.136
> AndHighMedDayTaxoFacets 14.78 (2.6%) 14.51
> (2.1%) -1.8% ( -6% - 2%) 0.013
> MedPhrase 142.26 (2.9%) 139.67
> (3.1%) -1.8% ( -7% - 4%) 0.058
> LowPhrase 21.22 (2.8%) 20.85
> (3.1%) -1.8% ( -7% - 4%) 0.061
> AndHighHighDayTaxoFacets 4.31 (4.5%) 4.24
> (3.2%) -1.7% ( -8% - 6%) 0.158
> BrowseDayOfYearTaxoFacets 4.70 (17.3%) 4.63
> (12.9%) -1.3% ( -26% - 34%) 0.787
> BrowseDateTaxoFacets 4.65 (16.9%) 4.59
> (12.9%) -1.2% ( -26% - 34%) 0.803
> MedSloppyPhrase 34.40 (2.9%) 34.02
> (4.0%) -1.1% ( -7% - 5%) 0.318
> MedTermDayTaxoFacets 13.85 (6.7%) 13.70
> (4.5%) -1.0% ( -11% - 10%) 0.563
> BrowseRandomLabelTaxoFacets 4.16 (12.7%) 4.11
> (9.7%) -1.0% ( -20% - 24%) 0.772
> LowSloppyPhrase 5.77 (2.2%) 5.72
> (3.3%) -0.9% ( -6% - 4%) 0.307
> LowSpanNear 53.67 (3.6%) 53.22
> (3.9%) -0.8% ( -8% - 6%) 0.481
> HighSpanNear 2.66 (4.8%) 2.63
> (5.4%) -0.8% ( -10% - 9%) 0.616
> MedIntervalsOrdered 25.88 (9.4%) 25.68
> (9.5%) -0.8% ( -17% - 20%) 0.797
> OrHighNotHigh 1043.34 (3.7%) 1037.43
> (4.4%) -0.6% ( -8% - 7%) 0.658
> HighSloppyPhrase 1.47 (3.4%) 1.46
> (4.2%) -0.6% ( -7% - 7%) 0.645
> MedSpanNear 11.52 (3.5%) 11.46
> (4.3%) -0.5% ( -7% - 7%) 0.685
> OrNotHighHigh 1615.92 (3.4%) 1608.09
> (3.6%) -0.5% ( -7% - 6%) 0.663
> BrowseRandomLabelSSDVFacets 3.11 (6.0%) 3.10
> (4.4%) -0.2% ( -10% - 10%) 0.881
> LowIntervalsOrdered 4.06 (8.9%) 4.06
> (8.9%) -0.2% ( -16% - 19%) 0.957
> OrHighNotMed 1188.76 (3.8%) 1187.46
> (4.4%) -0.1% ( -7% - 8%) 0.933
> OrNotHighMed 1220.26 (3.1%) 1219.23
> (3.7%) -0.1% ( -6% - 6%) 0.938
> AndHighMed 115.92 (3.6%) 116.03
> (3.3%) 0.1% ( -6% - 7%) 0.928
> Fuzzy1 111.98 (3.2%) 112.15
> (3.5%) 0.1% ( -6% - 7%) 0.889
> HighIntervalsOrdered 5.14 (7.5%) 5.15
> (7.3%) 0.2% ( -13% - 16%) 0.937
> OrHighNotLow 1222.80 (4.1%) 1226.76
> (4.7%) 0.3% ( -8% - 9%) 0.817
> TermDTSort 51.02 (14.1%) 51.21
> (18.9%) 0.4% ( -28% - 38%) 0.944
> HighTerm 1570.53 (3.7%) 1578.45
> (4.4%) 0.5% ( -7% - 8%) 0.693
> BrowseDayOfYearSSDVFacets 4.26 (3.9%) 4.28
> (9.1%) 0.5% ( -12% - 14%) 0.811
> AndHighHigh 40.61 (4.1%) 40.83
> (4.1%) 0.5% ( -7% - 9%) 0.681
> MedTerm 2002.17 (3.6%) 2013.12
> (4.3%) 0.5% ( -7% - 8%) 0.659
> Respell 67.74 (3.8%) 68.14
> (3.3%) 0.6% ( -6% - 8%) 0.594
> LowTerm 1633.26 (2.8%) 1643.86
> (2.6%) 0.6% ( -4% - 6%) 0.444
> OrHighMed 52.80 (3.7%) 53.17
> (3.8%) 0.7% ( -6% - 8%) 0.551
> HighTermDayOfYearSort 61.86 (10.2%) 62.31
> (13.0%) 0.7% ( -20% - 26%) 0.846
> Fuzzy2 33.05 (3.1%) 33.31
> (3.1%) 0.8% ( -5% - 7%) 0.420
> OrHighHigh 40.94 (4.1%) 41.27
> (3.6%) 0.8% ( -6% - 8%) 0.513
> PKLookup 204.53 (5.7%) 206.21
> (4.9%) 0.8% ( -9% - 12%) 0.623
> BrowseMonthSSDVFacets 4.65 (4.4%) 4.74
> (11.8%) 2.0% ( -13% - 19%) 0.488
> HighTermTitleBDVSort 50.18 (11.7%) 51.93
> (18.5%) 3.5% ( -23% - 38%) 0.475
> Prefix3 83.02 (12.3%) 86.16
> (12.9%) 3.8% ( -19% - 33%) 0.343
> Wildcard 61.79 (5.6%) 64.22
> (7.4%) 3.9% ( -8% - 17%) 0.058
> HighTermMonthSort 50.81 (16.0%) 53.56
> (16.4%) 5.4% ( -23% - 44%) 0.291
> IntNRQ 56.84 (31.8%) 62.62
> (26.8%) 10.2% ( -36% - 100%) 0.275
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
