mayya-sharipova commented on a change in pull request #601: URL: https://github.com/apache/lucene/pull/601#discussion_r784021962
########## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90HnswVectorsWriter.java ########## @@ -145,6 +139,64 @@ public void writeField(FieldInfo fieldInfo, KnnVectorsReader knnVectorsReader) throw new IllegalArgumentException( "Indexing an HNSW graph requires a random access vector values, got " + vectors); } + + long vectorDataLength = vectorData.getFilePointer() - vectorDataOffset; + long vectorIndexLength = vectorIndex.getFilePointer() - vectorIndexOffset; + writeMeta( + fieldInfo, + vectorDataOffset, + vectorDataLength, + vectorIndexOffset, + vectorIndexLength, + count, + docIds); + writeGraphOffsets(meta, offsets); + } + + @Override + public void mergeField(FieldInfo fieldInfo, MergeState mergeState) throws IOException { + if (mergeState.infoStream.isEnabled("VV")) { + mergeState.infoStream.message("VV", "merging " + mergeState.segmentInfo); + } + + writeVectorDataPadding(); + long vectorDataOffset = vectorData.getFilePointer(); + + // write the merged vector data to a temporary file + VectorValues vectors = MergedVectorValues.mergeVectorValues(fieldInfo, mergeState); + IndexOutput tempVectorData = Review comment: I am wondering if we need a temporary file at all? Before building a graph we can write merged vectorValues into the `vectorData` file and then open an IndexInput from this newly written data` IndexInput bytesSlice = vectorData.slice(..` to be used in building `OffHeapVectorValues`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org