jpountz commented on a change in pull request #601: URL: https://github.com/apache/lucene/pull/601#discussion_r787103602
########## File path: lucene/core/src/java/org/apache/lucene/codecs/KnnVectorsWriter.java ########## @@ -48,7 +42,11 @@ public abstract void writeField(FieldInfo fieldInfo, KnnVectorsReader knnVectors /** Called once at the end before close */ public abstract void finish() throws IOException; - /** Merge the vector values from multiple segments, for all fields */ + /** + * Merges the segment vectors for all fields. across all fields. This default implementation Review comment: did you mean something like this? ```suggestion * Merges the segment vectors for all fields across all segments. This default implementation ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org