jpountz commented on pull request #615: URL: https://github.com/apache/lucene/pull/615#issuecomment-1019092114
@msokolov I didn't run any benchmark. My intuition is that it shouldn't make things slower since this replaces an abstraction that runs one or more times per `NeighborQueue#add` call (every `LongHeap#upHeap` call) with an abstraction that runs exactly once per `NeighborQueue#add` call. It might help make the heap faster as a follow-up though, e.g. I think it's going to make [LUCENE-10383](https://issues.apache.org/jira/browse/LUCENE-10383) easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
