rmuir commented on pull request #692:
URL: https://github.com/apache/lucene/pull/692#issuecomment-1049894634
If this is literally all about "style" issue then let's be open and honest
about that. I am fine with:
```
/** sugar: to just make code look pretty, nothing else */
public BulkAdder grow(long numDocs) {
grow((int) Math.min(Integer.MAX_VALUE, numDocs));
}
```
But I think it is wrong to have constructors taking `Terms` and
`PointValues` already: it is just more useless complexity and "leaky
abstraction" from the terrible cost estimation.
And I definitely think having two separate classes just for the cost
estimation is way too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
