rmuir commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1064044898
I only looked at the high-level design so far, this seems to be a good approach @mocobeta ! Thank you for tackling it. I think the bottom-up approach is a good one, and splitting out the morphological data into separate interface makes sense to me. I would suggest reconsidering the name `MorphAttributes`, mostly because "Attributes" already has a complex meaning within lucene analysis. Some possibilities (not exhaustive list): * `MorphData` * `DictionaryData` I will do more review and testing, I am digging into it in detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
