[ 
https://issues.apache.org/jira/browse/LUCENE-10463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505195#comment-17505195
 ] 

Dawid Weiss commented on LUCENE-10463:
--------------------------------------

There are a number of things that rely on the java version,Tomoko - when Adrien 
made a bump to Java 17 we kept discovering that "minimum bar" in various places 
of the code. Maybe it'd be good to try to cover all of those (or most of those) 
under one issue? 

As far as I understand - the smoke tester's reason to exist is to have an 
external, final validation of things. If w tie it to the build then that 
validation will no longer be independent. Speaking for myself, I think it's 
fine if we move this check to an integration test within distribution.tests but 
I recall some discussions asking for the script to be a separate validation 
check.

> Make smoke tester script work on main branch (java 17)
> ------------------------------------------------------
>
>                 Key: LUCENE-10463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10463
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Tomoko Uchida
>            Priority: Major
>
> The smoke tester script has been obsoleted on main after upgrading to Java 
> 17. To enable nightly smoke tests on Jenkins for main, its target java 
> version should be bumped to 17.
> In addition to bump the java version, it looks it should be refactored not to 
> hard-code target java version. I feel it'd be better to make it coordinate 
> with the Gradle distribution task.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to