mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826294904
##########
File path: lucene/distribution/src/binary-release/bin/luke.cmd
##########
@@ -18,21 +18,17 @@
SETLOCAL
SET MODULES=%~dp0..
-IF DEFINED LAUNCH_CMD GOTO testing
REM Windows 'start' command takes the first quoted argument to be the title of
the started window. Since we
REM quote the LAUNCH_CMD (because it can contain spaces), it misinterprets it
as the title and fails to run.
REM force the window title here.
SET LAUNCH_START=start "Lucene Luke"
+
+IF DEFINED LAUNCH_CMD GOTO testing
SET LAUNCH_CMD=javaw
SET LAUNCH_OPTS=
goto launch
:testing
-REM For distribution testing we don't use start and pass an explicit java
command path,
-REM This is required because otherwise we can't block on luke invocation and
can't intercept
-REM the return status. We also force UTF-8 encoding so that we don't have to
interpret the output in
-REM an unknown local platform encoding.
Review comment:
This comment was wrongly removed; should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
