mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1070788886
I think I finished what I'd like to make changes in kuromoji and nori. Now, `ConnectionCosts`/`ConnectionCostsWriter` and `CharacterDefinition`/`CharacterDefinitionWriter` are also reside in `analyzers-common` in a very similar way to `BinaryDictionary`/`BinaryDictionaryWriter`. I manually checked the shared code is exactly the same for kuromoji and nori in the current `main` (in other words, they were copied and have never been changed so far). Also, `gradlew regenerate --rerun-tasks` does not change the generated dictionary files for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
