Yuti-G commented on a change in pull request #747:
URL: https://github.com/apache/lucene/pull/747#discussion_r830539688
##########
File path:
lucene/facet/src/test/org/apache/lucene/facet/sortedset/TestSortedSetDocValuesFacets.java
##########
@@ -1221,6 +1326,12 @@ public void testRandomHierarchicalFlatMix() throws
Exception {
assertEquals(expectedAllDims, actualAllDims);
+ // test getTopDims(1, 10)
+ if (actualAllDims.size() > 0) {
+ List<FacetResult> topDimsResults1 = facets.getTopDims(1, 10);
Review comment:
> I didn't really have a lot of real feedback, just minor nits here and
there. I did want to say that I have a PR out for a benchmark that compares the
faceting API performance for SSDV vs taxonomy for high cardinality hierarchical
faceting. Here is the link:
[mikemccand/luceneutil#166](https://github.com/mikemccand/luceneutil/pull/166).
We should add `getTopDims` to this benchmark once it is done :)
Thanks @mdmarshmallow for all the great feedback! This is my first official
PR and really appreciate all the suggestions. I'd like to add `getTopDims`to
benchmark once it is done and can I ask you questions if I come across any?
Thanks again :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
