jpountz commented on a change in pull request #737:
URL: https://github.com/apache/lucene/pull/737#discussion_r831103798
##########
File path:
lucene/highlighter/src/java/org/apache/lucene/search/highlight/WeightedSpanTermExtractor.java
##########
@@ -309,11 +309,11 @@ protected void extractWeightedSpanTerms(
final IndexSearcher searcher = new IndexSearcher(getLeafContext());
searcher.setQueryCache(null);
if (mustRewriteQuery) {
+ final SpanQuery rewrittenQuery = (SpanQuery)
spanQuery.rewrite(getLeafContext().reader());
Review comment:
Based on the discussion we had on LUCENE-10477, let's rewrite in a
for-loop like Indexsearcher#rewrite does?
https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.0.0/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java#L665-L671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
