mocobeta commented on pull request #740: URL: https://github.com/apache/lucene/pull/740#issuecomment-1078824500
>> I added test modules analysis/kuromoji.tests and analysis/nori.tests to make sure that both tokenizers correctly load the dictionary resources and work in module-mode. They are tiny tests but it'd be good to have ones for sanity checks. > This is not needed due to the improved TestRandomChains. This one instantiates all analyzer compients from module system. I removed the test modules. If we need specific tests for kuromoji or nori at some point in the future, then we will be able to re-add them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
