[
https://issues.apache.org/jira/browse/LUCENE-10454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-10454:
----------------------------------
Status: Open (was: Open)
WeightMatches is the default as of 9.0: LUCENE-9431 -- the ramifications of
this early term extraction is nullified in this case and your test will pass.
When WeightMatches isn't being used, there is at least PhraseHelper which does
extraction and attempts to know wether it should rewrite the query or not.
Perhaps the UH should see that terms is empty and fallback on PhraseHelper.
See my patch; tests pass including yours. It's imperfect though.... if there
are position sensitive terms or MTQ/automata, this won't work I suppose.
> UnifiedHighlighter can miss terms because of query rewrites
> -----------------------------------------------------------
>
> Key: LUCENE-10454
> URL: https://issues.apache.org/jira/browse/LUCENE-10454
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Julie Tibshirani
> Priority: Minor
> Attachments: LUCENE-10454-fix.patch, LUCENE-10454.patch
>
>
> Before extracting terms from a query, UnifiedHighlighter rewrites the query
> using an empty searcher. If the query rewrites to MatchNoDocsQuery when the
> reader is empty, then the highlighter will fail to extract terms. This is
> more of an issue now that we rewrite BooleanQuery to MatchNoDocsQuery when
> any of its required clauses is MatchNoDocsQuery
> (https://issues.apache.org/jira/browse/LUCENE-10412). I attached a patch
> showing the problem.
> This feels like a pretty esoteric issue, but I figured it was worth raising
> for awareness. I think it only applies when weightMatches=false, which isn't
> the default. I couldn't find any existing queries in Lucene that would be
> affected.
> We ran into it while upgrading Elasticsearch to the latest Lucene snapshot,
> since a couple custom queries rewrite to MatchNoDocsQuery when the reader is
> empty.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
