gsmiller commented on pull request #747: URL: https://github.com/apache/lucene/pull/747#issuecomment-1080958647
Thanks for running the benchmarks. The regression to taxo-faceting seems weird indeed since you didn't touch that code at all (as you point out). Maybe double-check that the only difference between your candidate and baseline repos is in fact this one change? The taxo faceting stuff can be a little noisy, but still... I went ahead and ran benchmarks with your change on my box as well since it was easy to do and don't see any regressions jumping out at me. So I'm confident this change is ready to go. I'll work on merging and backporting here in a little bit. Thanks! ``` TaskQPS baseline StdDevQPS candidate StdDev Pct diff p-value Prefix3 112.09 (8.0%) 106.11 (8.6%) -5.3% ( -20% - 12%) 0.041 BrowseDayOfYearSSDVFacets 13.10 (20.8%) 12.61 (19.0%) -3.7% ( -36% - 45%) 0.555 IntNRQ 119.06 (12.9%) 115.58 (18.0%) -2.9% ( -29% - 32%) 0.554 HighTermMonthSort 136.28 (15.2%) 133.62 (13.5%) -2.0% ( -26% - 31%) 0.667 HighTermDayOfYearSort 76.04 (21.2%) 74.87 (11.7%) -1.5% ( -28% - 39%) 0.775 MedSloppyPhrase 135.42 (3.0%) 133.54 (4.8%) -1.4% ( -8% - 6%) 0.275 LowSloppyPhrase 96.57 (2.8%) 95.24 (3.5%) -1.4% ( -7% - 5%) 0.170 OrNotHighLow 1002.65 (2.6%) 989.38 (2.4%) -1.3% ( -6% - 3%) 0.094 AndHighMed 217.28 (3.2%) 214.70 (2.9%) -1.2% ( -7% - 5%) 0.225 OrHighMed 151.51 (3.8%) 149.74 (2.7%) -1.2% ( -7% - 5%) 0.265 MedPhrase 76.05 (3.2%) 75.25 (2.8%) -1.1% ( -6% - 5%) 0.266 MedTerm 1667.21 (4.6%) 1652.30 (4.9%) -0.9% ( -9% - 8%) 0.550 HighSloppyPhrase 26.50 (2.8%) 26.26 (4.3%) -0.9% ( -7% - 6%) 0.442 OrHighHigh 30.91 (4.2%) 30.64 (3.0%) -0.9% ( -7% - 6%) 0.448 LowPhrase 139.61 (3.4%) 138.39 (2.9%) -0.9% ( -6% - 5%) 0.379 AndHighHigh 66.53 (4.7%) 66.12 (4.1%) -0.6% ( -8% - 8%) 0.656 HighPhrase 219.08 (4.2%) 217.79 (3.7%) -0.6% ( -8% - 7%) 0.637 Wildcard 63.45 (2.6%) 63.14 (3.1%) -0.5% ( -5% - 5%) 0.585 BrowseDateSSDVFacets 2.33 (9.8%) 2.32 (9.7%) -0.5% ( -18% - 21%) 0.879 AndHighLow 709.83 (4.9%) 706.66 (4.4%) -0.4% ( -9% - 9%) 0.762 HighTerm 1717.46 (3.7%) 1710.17 (5.5%) -0.4% ( -9% - 9%) 0.774 OrNotHighHigh 1573.17 (2.4%) 1566.71 (3.3%) -0.4% ( -5% - 5%) 0.654 LowTerm 2058.72 (3.5%) 2050.32 (3.8%) -0.4% ( -7% - 7%) 0.723 Fuzzy2 40.65 (1.5%) 40.48 (1.6%) -0.4% ( -3% - 2%) 0.417 Respell 63.85 (1.3%) 63.68 (1.7%) -0.3% ( -3% - 2%) 0.561 Fuzzy1 96.68 (1.5%) 96.52 (1.7%) -0.2% ( -3% - 3%) 0.742 OrNotHighMed 1134.72 (2.6%) 1133.02 (3.0%) -0.2% ( -5% - 5%) 0.866 OrHighLow 524.60 (3.5%) 524.69 (2.6%) 0.0% ( -5% - 6%) 0.986 LowSpanNear 14.45 (2.4%) 14.47 (2.5%) 0.1% ( -4% - 5%) 0.891 MedSpanNear 79.05 (3.0%) 79.16 (3.1%) 0.1% ( -5% - 6%) 0.889 HighSpanNear 6.91 (4.0%) 6.93 (4.1%) 0.3% ( -7% - 8%) 0.821 LowIntervalsOrdered 19.99 (4.4%) 20.06 (3.6%) 0.3% ( -7% - 8%) 0.786 MedIntervalsOrdered 26.31 (4.7%) 26.41 (3.8%) 0.4% ( -7% - 9%) 0.796 OrHighNotHigh 1077.33 (3.2%) 1082.44 (3.8%) 0.5% ( -6% - 7%) 0.669 OrHighNotLow 1396.37 (3.8%) 1404.14 (4.2%) 0.6% ( -7% - 8%) 0.664 PKLookup 169.17 (2.7%) 170.37 (3.1%) 0.7% ( -4% - 6%) 0.440 AndHighHighDayTaxoFacets 16.20 (1.9%) 16.32 (1.9%) 0.7% ( -3% - 4%) 0.229 OrHighMedDayTaxoFacets 12.05 (3.7%) 12.15 (4.0%) 0.8% ( -6% - 8%) 0.504 AndHighMedDayTaxoFacets 29.61 (2.2%) 29.91 (1.5%) 1.0% ( -2% - 4%) 0.085 HighIntervalsOrdered 11.20 (10.3%) 11.31 (9.3%) 1.1% ( -16% - 23%) 0.735 OrHighNotMed 1138.85 (3.5%) 1151.60 (3.8%) 1.1% ( -5% - 8%) 0.331 TermDTSort 144.73 (16.2%) 146.39 (11.7%) 1.1% ( -23% - 34%) 0.798 BrowseRandomLabelSSDVFacets 9.22 (7.5%) 9.38 (9.1%) 1.7% ( -13% - 19%) 0.529 BrowseRandomLabelTaxoFacets 18.62 (14.1%) 18.94 (11.5%) 1.7% ( -20% - 31%) 0.670 MedTermDayTaxoFacets 47.08 (4.3%) 47.94 (3.7%) 1.8% ( -5% - 10%) 0.150 BrowseDayOfYearTaxoFacets 22.69 (18.3%) 23.13 (15.9%) 2.0% ( -27% - 44%) 0.717 BrowseDateTaxoFacets 22.60 (18.0%) 23.07 (15.6%) 2.1% ( -26% - 43%) 0.696 BrowseMonthTaxoFacets 28.93 (19.2%) 29.54 (15.1%) 2.1% ( -27% - 45%) 0.699 BrowseMonthSSDVFacets 13.68 (21.2%) 14.25 (24.9%) 4.2% ( -34% - 63%) 0.565 HighTermTitleBDVSort 36.73 (20.6%) 39.65 (32.0%) 8.0% ( -36% - 76%) 0.349 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org