BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r838245085
##########
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##########
@@ -163,6 +164,57 @@ public void testInsertWithOverflow() {
assertEquals((Integer) 2, pq.top());
}
+ public void testAddAllToEmptyQueue() {
+ Random random = random();
+ int size = 10;
+ List<Integer> list = new ArrayList<>();
+ for (int i = 0; i < size; i++) {
+ list.add(random.nextInt());
+ }
+ IntegerQueue pq = new IntegerQueue(size);
+ pq.addAll(list);
+
+ pq.checkValidity();
+ assertOrderedWhenDrained(pq, list);
+ }
+
Review comment:
Hm, tests passed locally, now some are failing - probably there is some
flakiness, need to check it.
UPD: OK, assertion diff is in line ending - I started this PR on another
machine where all checks and tests succeeded, which is currently unusable and
switched to the Windows machine with CRLF line endings - it affected checksum
change (fails on Windows machine because I have CRLF in _all_ files) and
apparently some tests - I think should be fine as I checked `testForceUCase` in
debugger and it didn't even enter the new method - I think it's just a local
issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
