[ 
https://issues.apache.org/jira/browse/LUCENE-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524262#comment-17524262
 ] 

Michael McCandless commented on LUCENE-10517:
---------------------------------------------

This is a very impressive performance jump for the "pure browse" faceting case! 
 I'll review the PR soon.   Thanks [~ChrisHegarty]!

> Improve performance of SortedSetDV faceting by iterating on class types
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-10517
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10517
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 9.1
>            Reporter: Chris Hegarty
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While analysing various profiles, [@grcevski|https://github.com/grcevski] and 
> I can came across this potential improvement.
> SortedSetDV faceting (and friends), can improve performance within tight 
> loops by using invokevirtual (rather than invokeinterface). The C2 JIT 
> compiler can produce slightly more optimal code in this case, and since these 
> loops are very hot, the impact can be significant (in the order of 10-30%).
> This issue is in some ways similar to, and builds upon, prior optimisations 
> in this area, like say LUCENE-5300 or more recently LUCENE-5309



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to