dweiss commented on PR #817:
URL: https://github.com/apache/lucene/pull/817#issuecomment-1104244458

   
[spotless-msg.txt](https://github.com/apache/lucene/files/8523965/spotless-msg.txt)
   
   This patch implements the idea I mentioned - create an additional build 
failure/ message if any of the spotless tasks fail (in any module). This has 
the disadvantage that the finalizing message can be separated from the "source" 
tasks that actually failed so if somebody is scanning top-to-bottom then it's 
not going to work.
   
   I also discovered that afterTask is deprecated and scheduled to be removed 
in the future - something to be aware of.
   
   I think we can apply your patch as it's simpler, Robert, and then maybe hope 
that the underlying issue is fixed in spotless (so that we can customize the 
task's message).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to