gautamworah96 opened a new pull request, #829: URL: https://github.com/apache/lucene/pull/829
In PR (https://github.com/apache/lucene/pull/762) we missed the case where a tempDir name was using `:` in the dir name. This test was passing in Linux, MacOS environments but ended up failing in Windows build systems. By adding these additional checks we will reduce cases of these bugs slipping through to our CI systems. The https://github.com/apache/lucene/pull/822 PR introduced a clean way for overriding the wrapPath(path) function and adding custom checks to different `<> extends FilterPath` classes. JIRA: https://issues.apache.org/jira/browse/LUCENE-10525 # Solution Add a new WindowsPath class that "checks" Paths before resolving them. # Tests Added a basic test to check the added logic. It is not randomized at the moment because WindowsFS does not have support for case-sensitive checks (and a random test can create duplicate file entries). There are some other questions as well that need some thought (about completeness of emulation etc, how to go about it, should we enable the tests in WindowsOS etc) # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/lucene/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
