mocobeta commented on code in PR #828: URL: https://github.com/apache/lucene/pull/828#discussion_r855707897
########## lucene/luke/src/java/org/apache/lucene/luke/app/desktop/LukeMain.java: ########## @@ -73,8 +73,8 @@ public static void main(String[] args) throws Exception { boolean sanityCheck = Arrays.asList(args).contains("--sanity-check"); if (sanityCheck && GraphicsEnvironment.isHeadless()) { - Logger.getGlobal().log(Level.SEVERE, "[Vader] Hello, Luke. Can't do much in headless mode."); - Runtime.getRuntime().exit(0); + Logger.getGlobal().log(Level.SEVERE, "Hello, Luke. Can't do much in headless mode."); + Runtime.getRuntime().exit(1); Review Comment: Oh, thanks for elaborating. I didn't worry about servers' resources to run the test, I just didn't want to force human admins to install the virtual display on every VMs. Anyway, the opt-in policy looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org