rmuir commented on PR #829: URL: https://github.com/apache/lucene/pull/829#issuecomment-1107342012
LOL, I figured I would just try to see if you would bite. I want to make it better, my windows knowledge is just less, so it takes me longer. Also spinning up VMs is somehow painful for me. We should really fix this thing to be better, I think this PR is a great step towards that. If we can simulate it "well enough" to catch the most common problems, it can prevent windows hassles and give better CI coverage of windows (even when it is fake). I'm not happy we run the "fake windows" relatively rarely on *nix, and never on windows. But the fake windows is nice for people that don't want to deal with real windows :) I just know I feel a lot better with occasionally having tests for IndexFileDeleter having to exercise their special windows retry logic, and so on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
