[
https://issues.apache.org/jira/browse/LUCENE-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526873#comment-17526873
]
Tomoko Uchida commented on LUCENE-10532:
----------------------------------------
Hi, I'm not familiar with the origins of {{@Slow}} annotation and have not even
used it, but perhaps some concrete figures might be useful for reference? I
measured the test execution time (wall clock time) several times with
combinations of "Ptests.slow" and "--max-workers" on a physical machine.
|| ||tests.slow=false||tests.slow=true||
|--max-workers=2|3m 58s|5m 17s|
|--max-workers=4|2m 31s|3m 7s|
|--max-workers=6|2m 25s|2m 22s|
|--max-workers=8|2m 6s|2m 8s|
4 to 8 workers would be reasonable choices on modern commodity machines to me
(in my case, I'm using Fedora OS on Core i7-8700 with 6 cores and Gradle
chooses 6 workers by default for me), then it looks there is no critical
difference between "tests.slow=false" and "tests.slow=true" in terms of wall
clock time, thanks to concurrent execution.
>From my viewpoint and use-case, +1 to remove {{@Slow}} and keep unit tests
>sane.
> Remove @Slow annotation
> -----------------------
>
> Key: LUCENE-10532
> URL: https://issues.apache.org/jira/browse/LUCENE-10532
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Priority: Major
>
> This annotation is useless, people have gotten so lazy about using it, that
> now there are proposals to mark tests that are not actually slow, with the
> @Slow annotation.
> Let's remove the annotation. I can't imagine a situation where we mark a test
> @Slow and i don't veto it. we can keep tests clean.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
